Revert #85176 addition of clone_from for ManuallyDrop
#85758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forwarding `clone_from` to the inner value changes the observable behavior, as previously the inner value would *not* be dropped by the default implementation.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Could you add a test for this behaviour? |
|
Where sould a test for this go?
…On May 28, 2021 4:45:41 PM EDT, Simonas Kazlauskas ***@***.***> wrote:
Could you add a test for this behaviour?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#85758 (comment)
|
|
ping from triage: @rustbot label: -S-waiting-on-review +S-waiting-on-author |
rustbot
added
S-waiting-on-author
|
The test can be written as either an unit test inside the crate that defines this datatype or as a |
nagisa
added
T-libs-api
|
We should discuss this issue to decide what behaviour we want. I'll open an issue for it. Once that decision is made, we should add a test for that behaviour to make sure it stays that way. But for now let's merge and backport this to avoid breakage. Thanks! @bors r+ rollup |
|
📌 Commit 5b2076f has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added
the
beta-accepted
|
☀️ Test successful - checks-actions |
|
Note: not backporting to 1.53, as #85176 is a 1.54 PR, so 1.53 did not have the override to revert. |
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 23, 2021
…ulacrum [beta] Bootstrap from stable This is the follow up to master/beta promotion, as well as the first round of backports: * Revert "Allow specifying alignment for functions rust-lang#81234" * Revert rust-lang#85176 addition of clone_from for ManuallyDrop rust-lang#85758 * rustdoc: revert deref recur to resume inclusion of impl ExtTrait<Local> for ExtType rust-lang#84867 * [beta] Update cargo rust-lang#86563 r? `@Mark-Simulacrum`
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…one-from, r=m-ou-se Revert rust-lang#85176 addition of `clone_from` for `ManuallyDrop` Forwarding `clone_from` to the inner value changes the observable behavior, as previously the inner value would *not* be dropped by the default implementation. Frankly, this is a super-niche case, so rust-lang#85176 is welcome to argue the behavior should be otherwise! But if we overrride it, IMO documenting the behavior would be good. Example: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=c5d0856686fa850c1d7ee16891014efb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarding
clone_fromto the inner value changes the observable behavior, as previously the inner value would not be dropped by the default implementation.Frankly, this is a super-niche case, so #85176 is welcome to argue the behavior should be otherwise! But if we overrride it, IMO documenting the behavior would be good.
Example: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=c5d0856686fa850c1d7ee16891014efb